Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance tests cannot run on v1.2.0 #3342

Closed
howardjohn opened this issue Sep 17, 2024 · 0 comments · Fixed by #3343
Closed

Conformance tests cannot run on v1.2.0 #3342

howardjohn opened this issue Sep 17, 2024 · 0 comments · Fixed by #3343
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@howardjohn
Copy link
Contributor

What happened: Almost all conformance tests fail on 1.2.0 with errors like no kind is registered for the type v1.Gateway in scheme

What you expected to happen: Conformance tests can run

This is caused by #3211. This overrides the passed in Client, Clientset and RestConfig. This overrides any customizations we make to those, notably the scheme (but not ONLY the scheme, so its likely we will want a fix that is not scoped to that).

I believe how its working in any case is due to controller-runtime using the global scheme from client-go by default, then DefaultOptions taking that and installing. If you don't use DefaultOptions then you don't hit this path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant