Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation should prevent protocol specific config errors on Gateways #827

Closed
robscott opened this issue Aug 25, 2021 · 6 comments · Fixed by #842
Closed

Validation should prevent protocol specific config errors on Gateways #827

robscott opened this issue Aug 25, 2021 · 6 comments · Fixed by #842
Assignees
@bishtsaurabh5
Labels
area/webhook good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@robscott
Copy link
Member

What would you like to be added:
We should validate the following:

TLSConfig is empty when the protocol is HTTP, TCP, or UDP.
Hostname is empty when the protocol is TCP or UDP.

Why this is needed:
This would help provide a better UX.
@robscott robscott added kind/feature Categorizes issue or PR as related to a new feature. area/webhook labels Aug 25, 2021
@robscott robscott mentioned this issue Aug 25, 2021
Merged
@hbagdi hbagdi added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 25, 2021
@sayantani11
Copy link

@robscott a bit more insight to the issue will be helpful

@robscott
Copy link
Member Author

Hey @sayantani11, we currently have Gateway validation defined here: https://github.com/kubernetes-sigs/gateway-api/blob/master/apis/v1alpha2/validation/gateway.go. For each Gateway listener, we need validation that prevents the fields described above from being set when the protocol does not allow it.

@bishtsaurabh5
Copy link
Contributor

Hey I am also interested in picking this issue , @sayantani11 have you started working on this ?

@sayantani11
Copy link

@bishtsaurabh5 No. I haven't. You can work on it. All yours.

@bishtsaurabh5
Copy link
Contributor

Thanks for the update @sayantani11

@bishtsaurabh5
Copy link
Contributor

/assign

@bishtsaurabh5 bishtsaurabh5 mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bishtsaurabh5 bishtsaurabh5

Labels
area/webhook good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add protocol specific validation for Gateway api bishtsaurabh5/gateway-api
4 participants
@robscott @hbagdi @bishtsaurabh5 @sayantani11