Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP CSI driver does not emit cloudprovider metrics #729

Open
gnufied opened this issue Mar 19, 2021 · 4 comments
Open

GCP CSI driver does not emit cloudprovider metrics #729

gnufied opened this issue Mar 19, 2021 · 4 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@gnufied
Copy link

gnufied commented Mar 19, 2021

The GCP CSI driver does not emit cloudprovider metrics which are emitted by intree cloudprovider.

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/gce/metrics.go

@mattcary
Copy link
Contributor

Is this necessary? Especially since the intree cloud provider is changing, it might be nicer if we allow ourselves to figure out the best way to report k8s vs CSI vs cloud provider latencies based on the current state of the world, rather than replicating obsolete metrics.

Even with migration I'm not sure we should continue supporting those metrics from PD CSI as they probably shouldn't be interpreted the same as they were with the intree driver as the CSI architecture is different (all the external controllers causing different latency behavior).

@Jiawei0227
Copy link
Contributor

I think we should emit cloud provider related metrics in the pd csi driver. This way we get an idea about where the time spend inside the driver. It does not need to be 100% the same name and meaning with the intree cloud provider metric, but we should expose something here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2021
@mattcary
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants