-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize: strategicMergePatch clobbers patched arrays #3934
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 20, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 20, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
Hi @joelanford, For now I think the best is we ensure that it is as it was before: #3937 |
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 20, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 20, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 20, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
This was referenced May 20, 2024
Closed
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 21, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 21, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 21, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 22, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 22, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 22, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this issue
May 23, 2024
Ensure that enabling the manager_metrics_patch.yaml in config/default/kustomization.yaml does not overwrite existing arguments in config/manager/manager.yaml. The patch now appends the --metrics-bind-address argument without replacing other arguments. More info: kubernetes-sigs#3934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What broke? What's expected?
When I enabled the
manager_metrics_patch.yaml
inconfig/default/kustomization.yaml
, it wiped out the arguments that I had setup in theconfig/manager/manager.yaml
.Reproducing this issue
Initialize project and build manifests with and without metrics patch commented:
Diff the manifests:
KubeBuilder (CLI) Version
v3.15.0
PROJECT version
v3
Plugin versions
go.kubebuilder.io/v4
Other versions
No response
Extra Labels
No response
The text was updated successfully, but these errors were encountered: