-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing kubebuilder annotation to the getting started document #1587
Add missing kubebuilder annotation to the getting started document #1587
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @natalefalco! |
Hi @natalefalco. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5d3da42
to
26b4772
Compare
/check-cla |
Hi @natalefalco, Really tks for your contribution 👍 . Just a few nits for we are able to merge it:
|
4d23657
to
ec60f35
Compare
/ok-to-test |
/test pull-kubebuilder-e2e-k8s-1-16-2 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, natalefalco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
I changed the documentation, so it will contain a working example
Previously, the example not generated the deep copy function required by the SchemeBuilder.Register
It fixes #1586 issue, that complains about the not out of box working example