config: add project-name config key and optional init --project-name
#1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/plugin/v3/init.go: add --project-name which sets a config's 'project-name' key
k8s-ci-robot
added
size/M
|
Holding for discussion /hold |
k8s-ci-robot
added
approved
camilamacedo86
approved these changes
Jul 22, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks! |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
LGTM |
2 tasks
joelanford
reviewed
Jul 23, 2020
| @@ -41,6 +41,9 @@ type Config struct { | |||
| // Repo is the go package name of the project root | |||
| Repo string `json:"repo,omitempty"` | |||
|
|
|||
| // ProjectName is the name of this controller project set on initialization. | |||
| ProjectName string `json:"project-name,omitempty"` | |||
There was a problem hiding this comment.
Just a nit here:
Since Kubernetes YAMLs usually use camelCase, should we make this projectName?
There was a problem hiding this comment.
probably :) @estroz want to follow up with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
project-nameconfig key and an optionalinit --project-nameto the v3-alpha plugin. Plugin authors for non-Go plugins will find such a key useful, asrepodoesn't make much sense for non-Go plugins. This reverts #1596 behavior.Changes:
/cc @pwittrock @camilamacedo86