✨ Added the changes for include finalizer as a default controller markers (v3+ only)

[prafull01]

Description of the change
Added a /finalizer kubebuilder marker as a default marker for the controller. This is to allow the update;patch;get operation on finalizer of the resource if the ownerReferencesPermissionEnforcement enabled on the cluster.

Motivation of the change
The kubebuilder operator doesn't work seamlessly on the vanilla kubernetes like openshift unless the finalizers permission marker is added on the Reconcile function.

Fixes #1654

[k8s-ci-robot]

Hi @prafull01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

/ok-to-test

[camilamacedo86]

it shows great 🥇

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, prafull01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prafull01]

/test pull-kubebuilder-e2e-k8s-1-14-1

[gabbifish]

Thank you for this, LGTM!

[joelanford]

@prafull01 I just realized that the issue I filed may have extraneous/unnecessary permissions. Reading the docs for OwnerReferencesPermissionEnforcement again, I see this:

This admission controller also protects the access to metadata.ownerReferences[x].blockOwnerDeletion of an object, so that only users with "update" permission to the finalizers subresource of the referenced owner can change it.

I think we can scope this down to just update permission on <resource>/finalizers.

[prafull01]

@prafull01 I just realized that the issue I filed may have extraneous/unnecessary permissions. Reading the docs for OwnerReferencesPermissionEnforcement again, I see this:

This admission controller also protects the access to metadata.ownerReferences[x].blockOwnerDeletion of an object, so that only users with "update" permission to the finalizers subresource of the referenced owner can change it.

I think we can scope this down to just update permission on <resource>/finalizers.

Done. Updated with exact permission :)

[prafull01]

/test pull-kubebuilder-e2e-k8s-1-16-2

[camilamacedo86]

All suggestions addressed.
Also, received more than 1 review and OKs. So

/lgtm