🐛 For go/v3 plugin: assign config to global config

[mrkm4ntr]

The global cfg is always nil because assigned cfg is local scoped.
v2 is already correct.

kubebuilder/pkg/plugins/golang/v2/scaffolds/internal/templates/controllers/controller_suitetest.go

Lines 164 to 165 in c0a0bb6

	var err error
	cfg, err = testEnv.Start()

[k8s-ci-robot]

Hi @mrkm4ntr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

/ok-to-test

Thank you for the contribution 🥇
Could you please change the PR commit and title for:

🐛 For go/v3 plugin: assign config to global config

That is used to generate the release notes and we need to make clear that the change is only for go/v3 plugin.

Also, not sure if I understand the problem. You are saying that the error occurs because we create the cfg locally instead of set the value from EnvTest in the global var right?
Could we try to clarify in the code via a comment that the cfg is defined globally and also where?

[camilamacedo86]

Just some nits for we get this one merged.
Thank you for the contribution

[mrkm4ntr]

Also, not sure if I understand the problem. You are saying that the error occurs because we create the cfg locally instead of set the value from EnvTest in the global var right?

Indeed.

Could we try to clarify in the code via a comment that the cfg is defined globally and also where?

Sorry, I'm not sure. The commend is required? Also for v2?

[camilamacedo86]

@mrkm4ntr,

Will you be able to add a comment to this one?

[mrkm4ntr]

/test pull-kubebuilder-e2e-k8s-1-16-15

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mrkm4ntr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/approved