Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add support to go 1.18 and for (go/v3), update envtest version to use k8s 1.24 #2714

Merged
merged 1 commit into from
Jun 8, 2022
Merged

✨ add support to go 1.18 and for (go/v3), update envtest version to use k8s 1.24 #2714

merged 1 commit into from
Jun 8, 2022

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jun 7, 2022 •
edited
Loading

Description

  • add support to go 1.18
  • update envtest version for k8s 1.24
  • update goreleaser, ci and tests to ensure that works with 1.18.

PS.: Note that we are here only bumping the scaffolds and not the Kubebuilder tool since we do not want for now to impact who consumes the tool. But we are also updating the tests and the versions used to build the tool to ensure that it can work with 1.18

Closes: #2559
Closes: #2561

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2022
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-14-10

@camilamacedo86 camilamacedo86 force-pushed the go-1.18 branch 2 times, most recently from ae18162 to b5a2254 Compare June 7, 2022 22:54
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 7, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 8, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 8, 2022
@camilamacedo86 camilamacedo86 force-pushed the go-1.18 branch 2 times, most recently from 362a288 to abf5414 Compare June 8, 2022 00:39
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 8, 2022
dims
dims reviewed Jun 8, 2022
View reviewed changes
testdata/project-v3-v1beta1/Makefile
@@ -2,7 +2,7 @@
# Image URL to use all building/pushing image targets
IMG ?= controller:latest
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.24.1
ENVTEST_K8S_VERSION = 1.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going backwards? 1.24.1 -> 1.21?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. A project that is scaffold with v1beta1 cannot work with k8s >= 1.22 so that cannot work with 1.24.1.
This sample is done using the crdversions v1beta1 and when this option is used we downgrade the scaffold to warn the users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the sample testdata/project-v3-v1beta1 is built using CRD v1beta1 and the optional flag crd-version=v1beta1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha!

@camilamacedo86 camilamacedo86 changed the title ✨ add support to go 1.18 ✨ add support to go 1.18 and ENVTEST to use k8s 1.24 Jun 8, 2022
@camilamacedo86 camilamacedo86 changed the title ✨ add support to go 1.18 and ENVTEST to use k8s 1.24 ✨ add support to go 1.18 (update envtest version for k8s 1.24) Jun 8, 2022
@camilamacedo86 camilamacedo86 changed the title ✨ add support to go 1.18 (update envtest version for k8s 1.24) ✨ add support to go 1.18. For (go/v3): update envtest version for k8s 1.24 Jun 8, 2022
@camilamacedo86 camilamacedo86 changed the title ✨ add support to go 1.18. For (go/v3): update envtest version for k8s 1.24 ✨ add support to go 1.18 and for (go/v3), update envtest version for k8s 1.24 Jun 8, 2022
@camilamacedo86 camilamacedo86 requested a review from dims June 8, 2022 01:19
@camilamacedo86 camilamacedo86 changed the title ✨ add support to go 1.18 and for (go/v3), update envtest version for k8s 1.24 ✨ add support to go 1.18 and for (go/v3), update envtest version to use k8s 1.24 Jun 8, 2022
@dims
Copy link
Member

dims commented Jun 8, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7601764 into kubernetes-sigs:master Jun 8, 2022
@sbueringer sbueringer mentioned this pull request Jun 8, 2022
Merged
@oscr oscr mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@AlmogBaku AlmogBaku Awaiting requested review from AlmogBaku

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support go 1.18
3 participants
@camilamacedo86 @dims @k8s-ci-robot