✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) #2785

camilamacedo86 · 2022-07-01T08:38:22Z

Description

Add new go/v4 alpha plugin that adds support for Apple Silicon
The new plugin uses the base language go v3 with kustomize/v2-alpha

Changes:

Add samples for go/v4 alpha
Add e2e tests for the new plugin
Add doc for the new plugin
Update quickstart and migration guide to let users be aware of
Remove unnecessary test for PROJECT v2 ( no longer supported )
Remove from the migration guide note to use go/v2 ( deprecated ) we do not want people using it anymore.

Closes: #1932

everettraven

First round. Mostly just a few docs wording changes and minor nits:

docs/book/src/migration/v2vsv3.md

docs/book/src/plugins/go-v4-plugin.md

docs/book/src/quick-start.md

test/e2e/v4/generate_test.go

everettraven · 2022-07-05T13:43:00Z

test/e2e/v4/plugin_cluster_test.go

+}
+
+var _ = Describe("kubebuilder", func() {
+	Context("project version 3", func() {


Nit:

Suggested change

Context("project version 3", func() {

Context("project version 4", func() {

The project version is 3 ( the project version is the schema version used for the PROJECT file) However, i think we might could add another context here that is not too helpful maybe.

Ah okay that makes sense. Thanks for clearing that up!

everettraven

/lgtm

k8s-ci-robot · 2022-07-05T17:53:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…pport for Apple Silicon) Co-authored-by: Bryce Palmer <everettraven@gmail.com>

k8s-ci-robot · 2022-07-05T17:57:51Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2022-07-05T18:04:07Z

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-21-2	`c04f181`	link	false	`/test pull-kubebuilder-e2e-k8s-1-21-2`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2022

k8s-ci-robot requested review from jmrodri and rashmigottipati July 1, 2022 08:38

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022

camilamacedo86 requested review from AlmogBaku and removed request for jmrodri and rashmigottipati July 1, 2022 08:38

camilamacedo86 changed the title ~~:sparkling: (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ ✨ : (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 1, 2022

camilamacedo86 changed the title ~~✨ : (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 1, 2022

camilamacedo86 requested a review from NikhilSharmaWe July 1, 2022 08:41

camilamacedo86 force-pushed the gov4 branch 2 times, most recently from aee538f to efbca80 Compare July 1, 2022 08:46

kubernetes-sigs deleted a comment from k8s-ci-robot Jul 1, 2022

camilamacedo86 changed the title ~~✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ WIP: ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 1, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022

camilamacedo86 force-pushed the gov4 branch 3 times, most recently from c059595 to a5dcd3a Compare July 1, 2022 09:13

camilamacedo86 changed the title ~~WIP: ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 1, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022

kubernetes-sigs deleted a comment from k8s-ci-robot Jul 1, 2022

camilamacedo86 mentioned this pull request Jul 1, 2022

Support for arm macOS #1932

Closed

4 tasks

camilamacedo86 changed the title ~~✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ WIP: ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 1, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022

camilamacedo86 force-pushed the gov4 branch from a5dcd3a to 145d5d8 Compare July 1, 2022 10:15

camilamacedo86 changed the title ~~WIP: ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 1, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022

kubernetes-sigs deleted a comment from k8s-ci-robot Jul 1, 2022

camilamacedo86 force-pushed the gov4 branch from 145d5d8 to 40f318a Compare July 4, 2022 14:37

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2022

camilamacedo86 force-pushed the gov4 branch from 40f318a to c531a90 Compare July 4, 2022 18:25

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2022

camilamacedo86 force-pushed the gov4 branch from c531a90 to 8f547ff Compare July 4, 2022 18:33

everettraven suggested changes Jul 5, 2022

View reviewed changes

camilamacedo86 changed the title ~~✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ WIP: ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 5, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022

camilamacedo86 force-pushed the gov4 branch from b0faa09 to 623f6f1 Compare July 5, 2022 16:59

camilamacedo86 changed the title ~~WIP: ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon)~~ ✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) Jul 5, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022

everettraven approved these changes Jul 5, 2022

View reviewed changes

k8s-ci-robot assigned everettraven Jul 5, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022

:sparkling: (go/v4-alpha) new alpha plugin using kustomize v4 (add su…

c04f181

…pport for Apple Silicon) Co-authored-by: Bryce Palmer <everettraven@gmail.com>

camilamacedo86 force-pushed the gov4 branch from 623f6f1 to c04f181 Compare July 5, 2022 17:57

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 5, 2022

camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022

k8s-ci-robot merged commit 1502ede into kubernetes-sigs:master Jul 5, 2022

camilamacedo86 deleted the gov4 branch July 6, 2022 11:16

camilamacedo86 mentioned this pull request Jul 12, 2022

Makefile scaffolding should generate target to install Kustomize with go install #2822

Closed

FillZpp mentioned this pull request Aug 16, 2022

unable to find a version that was supported for platform darwin/arm64 when execute make test kubernetes-sigs/controller-runtime#1809

Closed

jonathan-innis mentioned this pull request Nov 17, 2023

ci: Bump the envtest default version to 1.28.x aws/karpenter-provider-aws#5109

Merged

3 tasks

RiRa12621 mentioned this pull request Nov 29, 2023

OperatorSDK 1.21 on M1 Macs fails to install kustomize operator-framework/operator-sdk#5810

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) #2785

✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) #2785

camilamacedo86 commented Jul 1, 2022 •

edited

Loading

everettraven left a comment

everettraven Jul 5, 2022

camilamacedo86 Jul 5, 2022

everettraven Jul 5, 2022

everettraven left a comment

k8s-ci-robot commented Jul 5, 2022

k8s-ci-robot commented Jul 5, 2022

k8s-ci-robot commented Jul 5, 2022

	Context("project version 3", func() {
	Context("project version 4", func() {

✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) #2785

✨ (go/v4-alpha) new alpha plugin using kustomize v4 (add support for Apple Silicon) #2785

Conversation

camilamacedo86 commented Jul 1, 2022 • edited Loading

Description

everettraven left a comment

Choose a reason for hiding this comment

everettraven Jul 5, 2022

Choose a reason for hiding this comment

camilamacedo86 Jul 5, 2022

Choose a reason for hiding this comment

everettraven Jul 5, 2022

Choose a reason for hiding this comment

everettraven left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 5, 2022

k8s-ci-robot commented Jul 5, 2022

k8s-ci-robot commented Jul 5, 2022

camilamacedo86 commented Jul 1, 2022 •

edited

Loading