Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically sync RBAC files in helm chart #943

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Automatically sync RBAC files in helm chart #943

merged 1 commit into from
Jul 4, 2023

Conversation

stuton
Copy link
Contributor

@stuton stuton commented Jul 3, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It helps to sync files from RBAC folder

Which issue(s) this PR fixes:

Fixes #926

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2023
@netlify
Copy link

netlify bot commented Jul 3, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c7fac33
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64a444fa1b2ef200081c3d6e

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2023
@stuton stuton force-pushed the automate-update-helm-chart branch from 66f3dc3 to 72cf69a Compare July 3, 2023 10:36
@k8s-ci-robot
Copy link
Contributor

Hi @stuton. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 3, 2023
stuton
stuton commented Jul 3, 2023
View reviewed changes
charts/kueue/templates/rbac/auth_proxy_role.yaml
verbs:
- create
- apiGroups:
- authentication.k8s.io
Copy link
Contributor Author

@stuton stuton Jul 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue regarding indents which yq makes. The flag -I0 doesn't work properly, that's mean ignore indent. Once the problem is solved, I will return the indents back.

stuton
stuton commented Jul 3, 2023
View reviewed changes
config/components/rbac/rayjob_editor_role.yaml
@@ -2,7 +2,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: kueue-rayjob-editor-role
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the naming the same as MPIJob

@tenzen-y
Copy link
Member

tenzen-y commented Jul 3, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2023
@stuton stuton force-pushed the automate-update-helm-chart branch from 72cf69a to c8739e7 Compare July 3, 2023 14:08
alculquicondor
alculquicondor reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

config/components/manager/kustomization.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, stuton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@stuton stuton force-pushed the automate-update-helm-chart branch from c8739e7 to c7fac33 Compare July 4, 2023 16:12
@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6d7a29d into kubernetes-sigs:main Jul 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jul 4, 2023
@alculquicondor
Copy link
Contributor

/retitle Automatically sync RBAC files in helm chart

@k8s-ci-robot k8s-ci-robot changed the title Update helm chart script Automatically sync RBAC files in helm chart Oct 24, 2023
@stuton stuton mentioned this pull request Oct 25, 2023
Closed
9 tasks
@trasc trasc deleted the automate-update-helm-chart branch March 12, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Automate helm chart updates
4 participants
@stuton @k8s-ci-robot @tenzen-y @alculquicondor