Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate exmaples from patchesStrategicMerge to patches #5200

Closed
2 tasks done
danistrebel opened this issue Jun 9, 2023 · 5 comments · Fixed by #5201
Closed
2 tasks done

Migrate exmaples from patchesStrategicMerge to patches #5200

danistrebel opened this issue Jun 9, 2023 · 5 comments · Fixed by #5201
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@danistrebel
Copy link
Contributor

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

Clean up referenfces for patchesStrategicMerge by replacing them with patches

Why is this needed?

patchesStrategicMerge was removed in >=5.0.0 (via #4911)

Can you accomplish the motivating task without this feature, and if so, how?

not in >= 5.0.0

What other solutions have you considered?

N/A

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@danistrebel danistrebel added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 9, 2023
@ashutosh887
Copy link

@danistrebel Is this issue resolved?

@danistrebel
Copy link
Contributor Author

Not sure I understand your question. I created the linked PR to fix the issue.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2024
@koba1t
Copy link
Member

koba1t commented Feb 15, 2024

I'm so sorry for the delayed response.
I think that is valuable work.

/triage accepted
/kind documentation

/assing @danistrebel

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/documentation Categorizes issue or PR as related to documentation. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 15, 2024
@koba1t
Copy link
Member

koba1t commented Feb 15, 2024

/assign @danistrebel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants