Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwok] Provided service for logs #217

Closed
wzshiming opened this issue Jan 14, 2023 · 4 comments · Fixed by #417
Closed

[kwok] Provided service for logs #217

wzshiming opened this issue Jan 14, 2023 · 4 comments · Fixed by #417
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@wzshiming
Copy link
Member

wzshiming commented Jan 14, 2023

# Match pods
kind: ClusterLogs
apiVersion: kwok.x-k8s.io/v1alpha1
metadata:
  name: cluster-logs-rules
spec:
  selector:
    matchNamespaces:
      - podNamespace
    matchNames:
      - podName
  logs: []
--- 
# Just for a Pod
kind: Logs
apiVersion: kwok.x-k8s.io/v1alpha1
metadata:
  name: podName
  namespace: podNamespace
spec:
  logs:
    - containers:
        - containerName

      # The first response is the contents of the logsFile
      # TODO: I'm not sure how to do support the --since-time, --since, --tail, --previous
      logsFile: /tmp/kwok.log

      # Follow up if true
      follow: true

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2023
@wzshiming wzshiming changed the title Provided service for logs [kwok] Provided service for logs Jan 14, 2023
@nikola-jokic
Copy link
Contributor

Can I take this one also? ☺️

@wzshiming
Copy link
Member Author

Yesh, I'm not sure how to implement --since-time, --since, --tail, --previous in this feature, It would be great if you could help refine it in the implementation.

@nikola-jokic
Copy link
Contributor

/assign

@wzshiming wzshiming added this to the v0.2 milestone Feb 6, 2023
@nikola-jokic
Copy link
Contributor

Update:
Started working on it. Added CRDs, implemented basic selection and need to figure out log streaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants