-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrap errors returned by JSON unmarshal #106
base: master
Are you sure you want to change the base?
Conversation
Currently `%v` is used inside an `Errorf` call, this means the original errors is lost and cannot be unwrapped to. By changing it to `%w` the error is preserved and can be retrieved with `errors.As`.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ThatsMrTalbot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ThatsMrTalbot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm
i don't see other %v left in yaml.go.
The build errors seem unrelated, may need to retry the jobs |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Currently
%v
is used inside anErrorf
call, this means the original errors is lost and cannot be unwrapped to.By changing it to
%w
the error is preserved and can be retrieved witherrors.As
.