Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Go 1.21 and later #119

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

skitt
Copy link
Member

@skitt skitt commented Oct 8, 2024

Something ends up requiring the slices package, which was added in Go 1.21.

See https://github.com/kubernetes-sigs/yaml/actions/runs/11232030744/job/31222775425?pr=118 for example:

Run GO111MODULE=off go get golang.org/x/lint/golint
  GO111MODULE=off go get golang.org/x/lint/golint
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.16.15/x64
package slices: unrecognized import path "slices": import path does not begin with hostname
Error: Process completed with exit code 1.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and jpbetz October 8, 2024 09:06
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2024
Something ends up requiring the slices package, which was added in Go
1.21.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@dims
Copy link
Member

dims commented Oct 8, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@dims dims mentioned this pull request Oct 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 50e7f43 into kubernetes-sigs:master Oct 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants