Update README.md and INSTALL.md for v6.0.0 #347
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/S
sttts
force-pushed
the
sttts-6-README
branch
from
db5223e to
43c13fc
Compare
sttts
changed the title
sttts
force-pushed
the
sttts-6-README
branch
from
43c13fc to
4170dc5
Compare
k8s-ci-robot
added
size/M
| | client-go 2.0 | Kubernetes main repo, 1.5 branch | ✓ | | ||
| | client-go 3.0 | Kubernetes main repo, 1.6 branch | ✓ | | ||
| | client-go 2.0 | Kubernetes main repo, 1.5 branch | = - | | ||
| | client-go 3.0 | Kubernetes main repo, 1.6 branch | = - | |
There was a problem hiding this comment.
these are 9 months ago. So we should officially deprecate them.
There was a problem hiding this comment.
(we promise 6 months)
There was a problem hiding this comment.
Waiting for approval by @cheftako as both @caesarxuchao and @lavalamp are out.
There was a problem hiding this comment.
@cheftako I read your 👍 as agreement.
| @@ -99,7 +99,7 @@ your project: | |||
| package: ( your project's import path ) # e.g. github.com/foo/bar | |||
| import: | |||
| - package: k8s.io/client-go | |||
| version: v2.0.0 | |||
There was a problem hiding this comment.
We clearly need to "fix" v2 but I'm a little worried that we are prescribing client v6. It seems live the "right" version is the fully compatible version for your kubernetes cluster or the latest such version if you have multiple kubernetes clusters with different versions. I am not seeing anything in the docs which explains that or that this the line you would want to change. I wonder if the different versions you are needing to change here were meant to convey message.
There was a problem hiding this comment.
It's documented in README.md (https://github.com/kubernetes/client-go/pull/347/files#diff-04c6e90faac2675aa89e2176d2eec7d8R82). But your comment shows once again that all this is far too complicated and spread over too many files. We cannot change this here in the PR, but I am for a major rewrite of the docs here. Compare #337 from your colleague who struggled as well from this documentation.
|
Merging this, with agreement on https://github.com/kubernetes/client-go/pull/347/files#r157535202. I think we all agree that we have to work on these two files and simplify things. But we should do that in follow-ups, it's nothing specific to v6. |
Prepare for v6.0.0 release.