Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable reviewable for kubernetes repos that don't use it #1881

Closed
spiffxp opened this issue Mar 3, 2018 · 4 comments
Closed

disable reviewable for kubernetes repos that don't use it #1881

spiffxp opened this issue Mar 3, 2018 · 4 comments
Assignees
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@spiffxp
Copy link
Member

spiffxp commented Mar 3, 2018

Discussion here: https://groups.google.com/forum/#!topic/kubernetes-dev/0RhWYvxW2XI

https://reviewable.kubernetes.io/repositories claims it's enabled for

  • kubernetes/client-go (doesn't make sense, PR's to this repo aren't accepted)
  • kubernetes/contrib
  • kubernetes/frakti
  • kubernetes/gengo
  • kubernetes/git-sync
  • kubernetes/heapster
  • kubernetes/helm (no webhook)
  • kubernetes/ingress-nginx
  • kubernetes/k8s.io
  • kubernetes/kops (webhook is disabled)
  • kubernetes/kube-state-metrics
  • kubernetes/kubernetes (all webhook deliveries are erroring)
  • kubernetes/node-problem-detector
  • kubernetes/test-infra (webhook is disabled)
  • kubernetes/website (webhook is disabled)

I heard objections to disabling reviewable for kubernetes/kubernetes, so I will leave that enabled. But I'm not actually sure it's properly hooked up given the webhook errors.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 3, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Mar 3, 2018

/sig contributor-experience
/assign

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Mar 3, 2018

Based on this query of PR's, gengo also recently used a reviewable review. Other uses of reviewable date back to Oct 2017.

I used the reviewable UI at https://reviewable.kubernetes.io/repositories to disable reviewable for all repos, except for:

  • kubernetes/gengo
  • kubernetes/kubernetes (shows "repository not found" error through the ui)

@spiffxp
Copy link
Member Author

spiffxp commented Mar 3, 2018

/assign thockin
I probably need @thockin's help to troubleshoot why it's not working for k/k if there is a desire to use it there. I'm guessing it must have stopped working a few months back and we just never noticed.

@thockin
Copy link
Member

thockin commented Mar 5, 2018

I disabled the integration for all. Given that it wasn't working, I have a hard time claiming it is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

3 participants