Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Add firewall rules and ing class clarifications #1672

Merged
merged 4 commits into from
Sep 2, 2016

Conversation

pdoreau
Copy link
Contributor

@pdoreau pdoreau commented Sep 1, 2016

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -78,6 +78,8 @@ Next we create a couple of Ingress rules
kubectl create -f examples/ingress.yaml
```

If your version of Kubernetes is higher than 1.3, you can restrict the ingress usage to NGINX with this annotation :`kubernetes.io/ingress.class: "nginx"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please surface this in the requirements section instead, something like:

if you're running multiple ingress controllers, or running on a cloudprovider that natively handles 
ingress, you need to specify the annotation `kubernetes.io/ingress.class: "nginx"` in all ingresses 
that you would like this controller to claim. Not specifying the annotation will lead to multiple 
ingress controllers claiming the same ingress. Specifying the wrong value will result in all ingress 
controllers ignoring the ingress. Multiple ingress controllers running in the same cluster was not 
supported in Kubernetes versions < 1.3.

@pdoreau
Copy link
Contributor Author

pdoreau commented Sep 2, 2016

@bprashanth fine to me, updated with your suggestion

### Running multiple ingress controllers

If you're running multiple ingress controllers, or running on a cloudprovider that natively handles
ingress, you need to specify the annotation kubernetes.io/ingress.class: "nginx" in all ingresses

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please quote this, ie kubernetes.io/ingress.class: "nginx"

@bprashanth
Copy link

LGTM just one nit

@bprashanth
Copy link

LGTM, please sign CLA

@pdoreau
Copy link
Contributor Author

pdoreau commented Sep 2, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 2, 2016
@bprashanth bprashanth added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0843745 into kubernetes-retired:master Sep 2, 2016
aledbf pushed a commit to aledbf/contrib that referenced this pull request Nov 10, 2016
Automatic merge from submit-queue

Add firewall rules and ing class clarifications
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants