-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[nginx-ingress-controller] Add annotation to add CORS support #1773
[nginx-ingress-controller] Add annotation to add CORS support #1773
Conversation
93d4f4a
to
6003eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the nit fix
} | ||
|
||
// ParseAnnotations parses the annotations contained in the ingress | ||
// rule used to indicate if the upstream servers should use SSL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
6003eb5
to
2fc43b1
Compare
[CLA-PING] @aledbf Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
|
I signed it |
Automatic merge from submit-queue |
@aledbf - can you give an example on how to enable cors in ingress, I added annotation |
@vinay-g this feature is not available in 0.8.3. Next release |
This change is