This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Add docs about the log format #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
cncf-cla: yes
bprashanth
reviewed
Sep 29, 2016
| @@ -362,6 +363,39 @@ In addition to this, you will need to add a firewall rule for each port this con | |||
|
|
|||
| Setting the annotation `kubernetes.io/ingress.class` to any value other than "nginx" or the empty string, will force the NGINX Ingress controller to ignore your Ingress. Do this if you wish to use one of the other Ingress controllers at the same time as the NGINX controller. | |||
|
|
|||
| ### Log format | |||
|
|
|||
| The default configuration uses a custom logging format to add additional información about the upstreams | |||
There was a problem hiding this comment.
s/about the upstreams/about upstreams/
| @@ -73,6 +73,9 @@ http { | |||
|
|
|||
| client_max_body_size "{{ $cfg.bodySize }}"; | |||
|
|
|||
| # disable warning | |||
| uninitialized_variable_warn off; | |||
There was a problem hiding this comment.
isn't this dangerous? is there a specific variable we're expecting to be uninitialized? if so pleas doc it
There was a problem hiding this comment.
isn't this dangerous?
No (uninitialized variables appear as empty in the log). I removed the section to avoid hiding this issue.
aledbf
force-pushed
the
fix-log-warn
branch
from
05da339
to
1963622
Compare
|
Thanks LGTM |
|
Automatic merge from submit-queue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is