This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[nginx-ingress-controller] Change structure of packages #1847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Oct 6, 2016
aledbf
force-pushed
the
ref-update-ip
branch
6 times, most recently
from
October 8, 2016 04:23
38f4b79
to
d7b2aeb
Compare
@bprashanth ready for a first review |
aledbf
changed the title
WIP: [nginx-ingress-controller] Change structure of packages
[nginx-ingress-controller] Change structure of packages
Oct 10, 2016
This was referenced Oct 12, 2016
Closed
@aledbf why this PR was closed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of this PR:
My wish is that to implement a new controller (like caddy) you just need to write a template for the tool, calling the generic code and a Dockerfile
replaces #1762
fixes #1665
fixes #1799
This change is