Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

[nginx-ingress-controller] Change structure of packages #1847

Closed
wants to merge 12 commits into from

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented Oct 6, 2016

Goals of this PR:

  • change the layout of the packages to be agnostic to the backend (first step)
  • remove most of the references to nginx
  • remove unnecessary function exports
  • add test
  • refactor how the status of the Ingress rules are keep up to date (using leader election)
  • move main inside cmd package

My wish is that to implement a new controller (like caddy) you just need to write a template for the tool, calling the generic code and a Dockerfile

replaces #1762

fixes #1665
fixes #1799


This change is Reviewable

@k8s-github-robot k8s-github-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2016
@aledbf aledbf force-pushed the ref-update-ip branch 6 times, most recently from 38f4b79 to d7b2aeb Compare October 8, 2016 04:23
@mqliang
Copy link

mqliang commented Oct 8, 2016

cc @ddysher @pendoragon

@aledbf
Copy link
Contributor Author

aledbf commented Oct 10, 2016

@bprashanth ready for a first review

@aledbf aledbf changed the title WIP: [nginx-ingress-controller] Change structure of packages [nginx-ingress-controller] Change structure of packages Oct 10, 2016
@aledbf aledbf closed this Oct 17, 2016
@kayrus
Copy link
Contributor

kayrus commented Oct 25, 2016

@aledbf why this PR was closed?

@aledbf
Copy link
Contributor Author

aledbf commented Oct 25, 2016

@kayrus because I'm working in the next version here. When ready I will open a PR in this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
6 participants