Skip to content

Commit

Permalink
Merge pull request #655 from brancz/patch-1
Browse files Browse the repository at this point in the history
Add additional metrics guideline violations to metrics overhaul
  • Loading branch information
k8s-ci-robot authored Dec 20, 2018
2 parents 14caa5b + 91c5adc commit d6510e0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ https://github.com/kubernetes/kubernetes/issues/68522

https://github.com/kubernetes/kubernetes/pull/63924

#### Prober metrics

Make prober metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the [Kubernetes instrumentation guidelines](https://github.com/kubernetes/community/blob/master/contributors/devel/instrumentation.md).

### Risks and Mitigations

Risks include users upgrading Kubernetes, but not updating their usage of Kubernetes exposed metrics in alerting and dashboarding potentially causing incidents to go unnoticed.
Expand All @@ -108,4 +112,4 @@ All metrics exposed by components from kubernetes/kubernetes follow Prometheus b

## Implementation History

Multiple pull requests have already been opened, but not merged as of writing of this document.
Multiple pull requests have already been opened, but not merged as of writing of this document.

0 comments on commit d6510e0

Please sign in to comment.