Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate KEPs and Design Proposals from k/community #613

Closed
wants to merge 1,146 commits into from
Closed

Migrate KEPs and Design Proposals from k/community #613

wants to merge 1,146 commits into from

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 3, 2018 •
edited
Loading

DO NOT MERGE.
Trying some git gymnastics to move KEPs and design proposals away from k/community...

/sig pm
/sig architecture
/assign
/hold

rel: kubernetes/community#2565

irfanurrehman and others added 30 commits March 13, 2018 21:41
@irfanurrehman
[Federated hpa design] Add some clarity and details
1dfe9c9
@irfanurrehman
Move the federated hpa design proposal to sig multicluster folder
0305f4b 
Also update a spelling suggestion by newly implemented hack/verify-spelling.sh
@fabriziopandini
kubeadm-join--master
9184e93
@AdamDang
Typo "API sever"->"API server"
d7219eb 
"API sever"->"API server"
@jbeda
Add more details and a concrete proposal for KEP-5
a8b1e32 
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
@jbeda
Clarify contributor instead of community
7869dad 
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
@jbeda
Update TOC, remove versioning concerns
4cf4122 
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
@jbeda
Add graduation criteria
3a69e7b 
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
@warmchang
Fix the hyper link to extending-api.md
78e307e 
Signed-off-by: William Zhang <warmchang@outlook.com>
@fqsghostcloud
fix some typo
6dcfeb3
@cimomo
Add hyperlink to the referenced issue
9b7f645
@jbeda
Move KEP-5 to implementable
c076fc9 
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
@k8s-ci-robot
Merge pull request kubernetes#1947 from fqsghostcloud/fix-some-typo
65e442b 
fix some typo
@verb
Update API of Troubleshooting Ephemeral Containers
7dc7a58 
- Report both v1.Container & v1.ContainerStatus in PodStatus
- Persist v1.Container as a container runtime label
- Start ephemeral containers from the kubelet pod worker
@verb
Update EphemeralContainers in apiserver not kubelet
a8d0dd6
@wangzhen127
Update seccomp design doc to add default profile
7f12222
@xingzhou
Proposal for growing FlexVolume size.
4d710a9 
Proposal for growing FlexVolume size, the feature ticket is at:
kubernetes#304

The original google doc for this proposal is at:
https://docs.google.com/document/d/1dwom9xQ3Fg5F_jJrybr0slp-QsO3_CKiisxzNRoMhec/edit?usp=sharing
@wangzhen127
update docker/default to runtime/default
c85008c
Proposal to add metadata about owning PVC in RBD Image
0ef4618
add a section on upgrade downgrade
171daba
@calebamiles
keps: unindent table of contents in cloud controller manager
f4c6895
@calebamiles
keps: Cleans up controler manager KEP
f1b0d39 
- remove `optional` from sections
- remove unused sections
@calebamiles
keps: Begin beta graduation requirements for controller manager
ddb6bef 
Mostly just propose a repository structure for existing providers
and punt on the details of accepting new cloud providers
@calebamiles
keps: Update KEP with updated repository structure
0344c20 
... also add Cloud Provider specific  SIGs as participants on this KEP.
Removes proposed repositories for Cloud Provider implementations
currently without a related SIG.
@calebamiles
keps: Fix typo and regenerate ToC for KEP 0002
0eaa2d5 
...but I'm sure there are other lurkers out there
@lavalamp
begin apply KEP
d07338b
@calebamiles
keps: Add ToC to 0006: apply
c0bb872
@k8s-ci-robot
Merge pull request kubernetes#1958 from jbeda/kep-5-implementable
24aad1b 
Move KEP-5 to implementable
@k8s-ci-robot
Merge pull request kubernetes#1707 from fabriziopandini/kubeadm-join-…
3d303b8 
…-master

KEP kubeadm join --master workflow
@kevdowney
Update ClusterRegistry API doc link
ed963c0 
Google Doc is now deprecated in favor of the markdown format in the community repo.

Link: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/multicluster/cluster-registry/api-design.md
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 3, 2018
@justaugustus
Copy link
Member Author

/meow

@k8s-ci-robot
Copy link
Contributor

@justaugustus: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 3, 2018
@justaugustus
Copy link
Member Author

/assign
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2018
@justaugustus
Copy link
Member Author

/assign @bgrant0607 @jdumars

@justaugustus justaugustus mentioned this pull request Sep 3, 2018
Closed
@justaugustus
Copy link
Member Author

/check-cla

@justaugustus justaugustus added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 3, 2018
@justaugustus justaugustus changed the title [WIP] Migrate KEPs and Design Proposals from k/community Migrate KEPs and Design Proposals from k/community Sep 3, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2018
@calebamiles
Copy link
Contributor

please don't do this yet. Moving the KEPs out of kubernetes/community needs to consider at least

  1. where the tooling for keps should go (in my opinion it should be in a kubernetes/keps repository or similar
  2. how web rendering (hugo or similar) will work and where that tooling should live

I've spent some time thinking about (2) and have just started spitballing (1).

For the KEPs themselves we need to rev the process a bit to

  1. drop numbers until a KEP has reasonable agreement on at least the motivation so that people stop trying to "reserve" numbers

  2. switch to a directory (rather than flat file) format for KEPs to accommodate experience reports and to allow the folks iterating on a KEP to take advantage of the OWNERS process and tooling (and create some basic tooling to attempt automatic-ish conversion of well formed KEPs). Given that it's relatively easy to extract just the KEPs from kubernetes/community I would suggest closing this PR and in favor of one that focuses narrowly on improving the KEP process itself as we discuss how to fold in the rest of the artifacts here

@justaugustus
Copy link
Member Author

@calebamiles -- Yep. The PR was more of a "This is what it could look like if we did this" thing than anything else. The PR will likely go stale before we lay out all of the pieces that we need in k/community.

  1. where the tooling for keps should go (in my opinion it should be in a kubernetes/keps repository or similar

Agreed that it should go in k/keps. I was thinking we'd rename k/features to k/keps, which works to reinforce the fact that KEPs are the currently accepted process. Related comment: kubernetes/community#2245 (comment)

  1. drop numbers until a KEP has reasonable agreement on at least the motivation so that people stop trying to "reserve" numbers

Agreed that the current numbering is broken (kubernetes/community#2245). Another thought we were kicking around was either dropping numbering altogether or creating issues (similar to feature issues in this repo) and using the issue number as the KEP number.

  1. switch to a directory (rather than flat file) format for KEPs to accommodate experience reports and to allow the folks iterating on a KEP to take advantage of the OWNERS process and tooling (and create some basic tooling to attempt automatic-ish conversion of well formed KEPs).

Big +1 here!

Given that it's relatively easy to extract just the KEPs from kubernetes/community I would suggest closing this PR and in favor of one that focuses narrowly on improving the KEP process itself as we discuss how to fold in the rest of the artifacts here

I'm going to leave this open for a little bit for the sake of discussion, but I wholeheartedly agree that there are steps to make the process more clear and discoverable and something like this is merely a subset of what that would look like.

Echoing some of the things I had in mind from kubernetes/community#2565 (comment) over here:

  • announce the forthcoming change
  • merge the k/features PR
  • set up blockade to prevent pushes to either dir in k/community
  • rename k/features to k/keps
  • migrate KEP / design proposal PRs to k/keps
  • create tombstones for files in both dirs in k/community
  • fix KEP / proposal links in k/keps issues
  • update docs in k/keps to clarify process
  • figure out the best way to reconcile the multiple OWNERS files between the two repos

@idvoretskyi
Copy link
Member

/cc

/assign

@justaugustus
Copy link
Member Author

Closing. We'll track this effort here: kubernetes/community#2730
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this PR.

In response to this:

Closing. We'll track this effort here: kubernetes/community#2730
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

Assignees

@idvoretskyi idvoretskyi

@justaugustus justaugustus

@jdumars jdumars

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.