Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatefulSets #137

Closed
10 of 23 tasks
apsinha opened this issue Oct 26, 2016 · 12 comments
Closed
10 of 23 tasks

StatefulSets #137

apsinha opened this issue Oct 26, 2016 · 12 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@apsinha
Copy link

apsinha commented Oct 26, 2016

Description

kubernetes/kubernetes#28718

Progress Tracker

  • Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
      • Design Proposal. This goes under docs/proposals. Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation. Paste link to merged design proposal here: PROPOSAL-NUMBER
      • Decide which repo this feature's code will be checked into. Not everything needs to land in the core kubernetes repo. REPO-NAME
      • Initial API review (if API). Maybe same PR as design doc. PR-NUMBER
        • Any code that changes an API (/pkg/apis/...)
        • cc @kubernetes/api
      • Identify shepherd (your SIG lead and/or kubernetes-pm@googlegroups.com will be able to help you). My Shepherd is: etune@google.com_ (and/or GH Handle)
        • A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
        • The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.
      • Identify secondary/backup contact point. My Secondary Contact Point is: replace.me@replaceme.com (and/or GH Handle)
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs
        • cc @kubernetes/docs on docs PR
        • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
        • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
      • Update release notes
  • Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@idvoretskyi idvoretskyi added this to the v1.5 milestone Oct 26, 2016
@idvoretskyi
Copy link
Member

@smarterclayton are you the right person to report here?

@apsinha
Copy link
Author

apsinha commented Oct 26, 2016

Please feel free to adjust / modify or even delete this issue (in case it
is a duplicate) - I did not see an issue for this feature, which I believe
is planned for 1.5 so created it.

On Wed, Oct 26, 2016 at 5:31 AM, Ihor Dvoretskyi notifications@github.com
wrote:

@smarterclayton https://github.com/smarterclayton are you the right
person to report here?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#137 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR0vm90Vr2HFFmmsvGNRsa5i_3_8EGeSks5q30gfgaJpZM4Kgnl7
.

Aparna Sinha
Product Manager
Kubernetes & GKE

650-283-6086 (m)

@idvoretskyi
Copy link
Member

@apsinha I have already re-checked the existing PetSet submitting issues here - there are no issues, proposing PetSets (they were implemented earlier that the feature submission process was established).

I would suggest to keep this one to track the PetSet activities.

@grodrigues3
Copy link
Contributor

@apsinha @smarterclayton what's the status of this? And can we rename the issue to StatefulSets to Beta

@idvoretskyi idvoretskyi changed the title PetSet to Beta StatefulSets to Beta Nov 9, 2016
@idvoretskyi
Copy link
Member

And can we rename the issue to StatefulSets to Beta

Done.

@spiffxp spiffxp added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Dec 1, 2016
@idvoretskyi idvoretskyi changed the title StatefulSets to Beta StatefulSets Dec 13, 2016
@idvoretskyi idvoretskyi modified the milestones: v1.6, v1.5 Dec 13, 2016
@idvoretskyi idvoretskyi added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed (deprecated label - do not use) beta-in-1.5 labels Jan 12, 2017
@apsinha
Copy link
Author

apsinha commented Feb 3, 2017

This is already done as for 1.5. We can remove it from 1.6 milestone unless its going GA?

@grodrigues3 grodrigues3 modified the milestones: next-milestone, v1.6 Feb 3, 2017
@grodrigues3 grodrigues3 removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 3, 2017
@grodrigues3
Copy link
Contributor

@apsinha @smarterclayton verifying that this feature is already beta and nothing is changing in 1.6?

@erictune
Copy link
Member

erictune commented Feb 3, 2017

@kow3ns

@erictune
Copy link
Member

erictune commented Feb 3, 2017

This is beta. May have minor changes in 1.6 but not going GA.

@idvoretskyi idvoretskyi modified the milestones: v1.6, next-milestone Feb 5, 2017
@idvoretskyi idvoretskyi added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 5, 2017
@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.6 Feb 7, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2017
@smarterclayton smarterclayton added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Dec 30, 2017
@smarterclayton smarterclayton modified the milestones: next-milestone, v1.9 Dec 30, 2017
@smarterclayton
Copy link
Contributor

This reached stability in 1.9 and subsequent improvements should be covered in other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

8 participants