Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress health check not following ReadinessProbe #317

Closed
matti opened this issue Jun 7, 2018 · 5 comments
Closed

Ingress health check not following ReadinessProbe #317

matti opened this issue Jun 7, 2018 · 5 comments

Comments

@matti
Copy link

matti commented Jun 7, 2018

with:

        readinessProbe:
          httpGet:
            path: /health
            port: 8080

the google health check is still /

Also confirmed by @Gogoro:

" When I create an ingress pointing to a service, which again points to a pod it just keeps hitting / instead of the path I defined in readinessProbe and livenessProbe. I can see in the logs that the pod itself checks itself easily, but the healthcheck goes ham on /."

In this discussion issue: #42

@nicksardo
Copy link
Contributor

PTAL at this comment: #241 (comment)

Also, this is only retrieved on new GCP healthcheck objects. If you're adding the readiness probe post ingress setup, nothing will change.

@JorritSalverda
Copy link

I have the same issue when changing the readinessProbe on existing applications I'm switching to GCE ingress. If the rolling update is slow an old readinessProbe is sometimes used. Would be nice to follow changes in the probe in order to update the health check. However since a service can resolve to pods with different readiness probes it might be useful to override the health check path in the ingress object with an annotation, although I'm not sure how that would work if ingress routes to multiple service. An annotation on the service instead?

@nicksardo
Copy link
Contributor

@JorritSalverda , Unfortunately, due to legacy behavior, that cannot be done. See #39

@irvifa
Copy link
Member

irvifa commented Sep 4, 2018

Have the same problem here, actually, I need to create my own health check path in the GCP UI after updating my ingress. I already used k8s version 10.2.

So what can we do @nicksardo ?

@irvifa
Copy link
Member

irvifa commented Oct 25, 2018

Seems like it's related to #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants