Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ingress.gcp.kubernetes.io/pre-shared-cert annotation #52

Closed
bowei opened this issue Oct 11, 2017 · 5 comments
Closed

Document ingress.gcp.kubernetes.io/pre-shared-cert annotation #52

bowei opened this issue Oct 11, 2017 · 5 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bowei
Copy link
Member

bowei commented Oct 11, 2017

Update GLBC documentation with this annotation + usage

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

Moved from kubernetes/ingress-nginx#396

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2018
@nicksardo nicksardo added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 7, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2018
@nikhiljindal
Copy link
Contributor

Not sure whats the scope of this issue. Is it for documentation on k8s.io/docs or documentation within this repo?
I updated docs in this repo to point out usage of that annotation: #144.
@bowei @nicksardo What else is required?

@nicksardo
Copy link
Contributor

The planned scope was just within this repo. I think your PR is sufficient. Thanks!
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants