Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GKE self managed script #758

Closed
KatrinaHoffert opened this issue May 24, 2019 · 1 comment
Closed

Update GKE self managed script #758

KatrinaHoffert opened this issue May 24, 2019 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@KatrinaHoffert
Copy link
Contributor

Kinda a follow up to #755, I noted a few other issues I had with the flow described in docs/deploy/gke/README.md. Firstly, the readme doesn't mention the need to update glbc.yaml for your custom image location. Secondly, the command flags are outdated and prevent the controller from running.

I want to also look into automating more of this or at least improving the documentation.

  • We already get the project name from gcloud
  • Network and subnetwork name are easily determined from gcloud container cluster describe (the cluster name is already provided to the setup script)
  • The node-instance-prefix should be determinable from the cluster name and we strangly don't even allow the user to continue if it doesn't make that expectation!
  • Node tags are a little harder. Get the instance groups from describe cluster, list instances, and describe those instances to get the network tags.

Zone should just be asked by the script. Should take the image URL in, too, so it can be just one command to set everything up.

I'll look into this. I already did the work of figuring out how to get that script to work for me and confirmed its working.

@rramkumar1
Copy link
Contributor

Closing since relevant PR has been merged.

Thanks @KatrinaHoffert !

@rramkumar1 rramkumar1 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants