Make prometheus metric names follow best practices

[discordianfish]

Hi,

I realized the metrics expose in ingress-nginx: https://github.com/kubernetes/ingress-nginx/blob/master/pkg/nginx/metric/collector/nginx.go#L57
Are not following the prometheus best practices: https://prometheus.io/docs/practices/naming/

I'm also not sure why

ingress-nginx/pkg/nginx/metric/collector/process.go

Line 79 in 7ffa0ae

p.data = namedProcessData{

was done, given that client-golang already exposes these metrics by default in a way that is consistent with any other prometheus instrumented golang application: https://github.com/prometheus/client_golang/blob/master/prometheus/go_collector.go#L22

[aledbf]

Are not following the prometheus best practices: https://prometheus.io/docs/practices/naming/

Can you open a PR to fix this?

was done, given that client-golang already exposes these metrics by default in a way that is consistent with any other prometheus instrumented golang application:

This stats are for the nginx process, not the go application. This two are separated.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[derekperkins]

👍

[discordianfish]

/remove-lifecycle stale
..but I don't know when I'll have time for a PR.