Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Missing checks in test #2362

Closed
2 of 6 tasks
aledbf opened this issue Apr 17, 2018 · 6 comments
Closed
2 of 6 tasks

WIP: Missing checks in test #2362

aledbf opened this issue Apr 17, 2018 · 6 comments
Labels
area/ingress kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

@Stono
Copy link
Contributor

Stono commented Apr 17, 2018

Here's an example sql injection request that should return a 403 if SecRuleEngine On is enabled:

❯ curl -s -o /dev/null -w '%{http_code}' "http://127.0.0.1?username=1'%20or%20'1'%20=%20'"
403

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2018

@Stono well, I will use your post for inspiration 😉
https://karlstoney.com/2018/02/23/nginx-ingress-modsecurity-and-secchatops/

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2018

@Stono please use quay.io/aledbf/nginx-ingress-controller:0.360

@ElvinEfendi
Copy link
Member

Dynamic configuration should return 503 if there is no endpoints

is done now:
https://github.com/kubernetes/ingress-nginx/blob/master/rootfs/etc/nginx/lua/balancer.lua#L171

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Jun 5, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 3, 2018
@aledbf aledbf closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ingress kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants