Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tls 1.3 in the nginx image #2384

Closed
dgregoire opened this issue Apr 20, 2018 · 12 comments · Fixed by #3296
Closed

Enable tls 1.3 in the nginx image #2384

dgregoire opened this issue Apr 20, 2018 · 12 comments · Fixed by #3296
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dgregoire
Copy link

FEATURE REQUEST

TLS1.3 in nginx, add the right ciphers to the default config, add TLS1.3 to the tls config string.

I can help if needed!

@aledbf
Copy link
Member

aledbf commented Apr 20, 2018

@dgregoire we are going to do that after the official support in nginx. Please check https://trac.nginx.org/nginx/ticket/1529 and https://twitter.com/RichSalz/status/986123531913134080

@aledbf aledbf added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 20, 2018
@aledbf
Copy link
Member

aledbf commented Jun 15, 2018

Closing. This is present in the nginx 1.15 cycle but that could take up to a year and also depends on the relase final release of TLS 1.3.
https://trac.nginx.org/nginx/milestone/1.15

@aledbf aledbf closed this as completed Jun 15, 2018
@weisjohn
Copy link

It would be nice to see this at least optionally enabled behind a setting in a ConfigMap, if possible, given that http://nginx.org/en/CHANGES says the following:

Changes with nginx 1.15.4                                        25 Sep 2018

    *) Feature: now the "ssl_early_data" directive can be used with OpenSSL.

and

Changes with nginx 1.15.3                                        28 Aug 2018

    *) Feature: now TLSv1.3 can be used with BoringSSL.

@aledbf
Copy link
Member

aledbf commented Oct 22, 2018

@weisjohn we need Openssl 1.1.1 to support TLS 1.3 (that version is present only in debian testing now)

@toutougabi
Copy link
Contributor

Now that Openssl 1.1.1 is merged is TLS 1.3 supported ?

@aledbf
Copy link
Member

aledbf commented Aug 6, 2019

@toutougabi yes since 0.21.0 but is not enabled by default. Please check https://kubernetes.github.io/ingress-nginx/user-guide/tls/#default-tls-version-and-ciphers

@nottrobin
Copy link

@aledbf it's not clear from those links why 1.3 isn't enabled by default?

@vitobotta
Copy link

Hi @aledbf I have set ssl-protocols to TLSv1.3 TLSv1.2 but I see no difference. TLS handshake still takes longer than 110ms for me. What else can I do?

@aledbf
Copy link
Member

aledbf commented Mar 26, 2020

TLS handshake still takes longer than 110ms for me. What else can I do?

How are you testing this? Did you use ssllabs.com/ssltest/analyze.html to check the configuration and https://www.webpagetest.org/runtest.php to check the behavior?
This is for a webapp or a REST API? I suggest you open a new issue with more information (like my previous questions) and some context about the scenario, i.e., where are you running, size of the vms, etc.

@vitobotta
Copy link

Hi @aledbf I was checking with curl but it wasn't build with support for 1.3. Fixed that, I see an improvement. Thanks :)

@JohnGalt1717
Copy link

www.ssllabs.com still shows that TLS 1.3 isn't enabled even with nginx.ingress.kubernetes.io/ssl-protocols: "TLSv1.3 TLSv1.2"

@takyon77
Copy link

takyon77 commented Aug 8, 2020

Like @JohnGalt1717 it seems that TLS 1.3 is not showing when trying to enable it:

kubectl -n nginx-ingress get cm nginx-config -o yaml | grep ssl-protocol
ssl-protocols: TLSv1.2 TLSv1.3

nmap --script ssl-enum-ciphers -p 443 'nginx-ingres pod IP' > |grep "TLSv|SSLv"
| SSLv3: No supported ciphers found
| TLSv1.2:

Is there something else to do to enable TLSv1.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants