Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use 308 for permanent-redirects? #2715

Closed
Stono opened this issue Jun 27, 2018 · 2 comments
Closed

Can we use 308 for permanent-redirects? #2715

Stono opened this issue Jun 27, 2018 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Stono
Copy link
Contributor

Stono commented Jun 27, 2018

Hey!

As you can see from this line:

Code: http.StatusMovedPermanently,

Requests configured with nginx.ingress.kubernetes.io/permanent-redirect, are being redirected with a 301.

I feel a 308 would be more appropriate https://httpstatuses.com/308 as this minimises the risk of clients changing POST to GET.

Ta!

@aledbf
Copy link
Member

aledbf commented Jun 27, 2018

@Stono yes but we need to make this configurable like in the configmap https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#http-redirect-code

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2018
@aledbf aledbf closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants