-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses recommended labels #2969
Comments
@ant31 can you be more specific about what are you requesting? |
@aledbf sure. This repo proposes several resources to install ingress-nginx, is it possible that update those resources to follow the official guideline? I can propose the PR |
Sure. This will be additional labels or we need to remove the existing ones? |
@ant31 is there a proposal in sig-apps for this feature? |
it has been discussed over a long period and now it's merged in the k8s.io/doc for reference here few documents/PR related to it:
It would be redoundant to keep both, it should not break anything to replace existing one, but it could be done in two times if you prefer |
No need. We can add a note in the changelog mentioning this change. |
@ant31 is there a plan to do something with this new standard labels once most of the users start using it? |
The official documentation recommends the usage of a common set of labels in all resources.
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels
The text was updated successfully, but these errors were encountered: