Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses recommended labels #2969

Closed
ant31 opened this issue Aug 22, 2018 · 7 comments · Fixed by #2970
Closed

Uses recommended labels #2969

ant31 opened this issue Aug 22, 2018 · 7 comments · Fixed by #2970

Comments

@ant31
Copy link
Member

ant31 commented Aug 22, 2018

The official documentation recommends the usage of a common set of labels in all resources.
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

@ant31 can you be more specific about what are you requesting?

@ant31
Copy link
Member Author

ant31 commented Aug 22, 2018

@aledbf sure.
As part of sig-apps we came to an agreement that the community should use the same set of labels to improve interoperability between application.
Instead of having many variants of a label with the same semantic, e.g app, k8s-app, name, app-name.... we should all use the same, in this case: app.kubernetes.io/name

This repo proposes several resources to install ingress-nginx, is it possible that update those resources to follow the official guideline?

I can propose the PR

@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

I can propose the PR

Sure.

This will be additional labels or we need to remove the existing ones?

@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

@ant31 is there a proposal in sig-apps for this feature?

@ant31
Copy link
Member Author

ant31 commented Aug 22, 2018

it has been discussed over a long period and now it's merged in the k8s.io/doc
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

for reference here few documents/PR related to it:
https://docs.google.com/document/d/1EVy0wRJRm5nogkHl38fNKbFrhERmSL_CLNE4cxcsc_M/edit#
kubernetes/website#7695
kubernetes/website#8703

This will be additional labels or we need to remove the existing ones?

It would be redoundant to keep both, it should not break anything to replace existing one, but it could be done in two times if you prefer

@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

but it could be done in two times if you prefer

No need. We can add a note in the changelog mentioning this change.

@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

@ant31 is there a plan to do something with this new standard labels once most of the users start using it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants