Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-forwarded-prefix is a boolean annotation, but documented as string #3670

Closed
denisw opened this issue Jan 17, 2019 · 2 comments
Closed

x-forwarded-prefix is a boolean annotation, but documented as string #3670

denisw opened this issue Jan 17, 2019 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@denisw
Copy link

denisw commented Jan 17, 2019

The documentation for the x-forwarded-prefix says:

To add the non-standard X-Forwarded-Prefix header to the upstream request with a string value, the following annotation can be used:

However, according to the code, x-forwarded-prefix is parsed as a boolean value that expects a "true". It seems like the docs need updating.

# What is documented:
nginx.ingress.kubernetes.io/x-forwarded-prefix: "/path"

# The reality:
nginx.ingress.kubernetes.io/x-forwarded-prefix: "true"
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2019
@aledbf
Copy link
Member

aledbf commented Apr 17, 2019

Closing. Fixed in #3786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants