Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No config reload is triggered when changing annotations (f.e. nginx.ingress.kubernetes.io/session-cookie-name) #3725

Closed
msiuts opened this issue Feb 5, 2019 · 0 comments · Fixed by #3740

Comments

@msiuts
Copy link

msiuts commented Feb 5, 2019

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/.):

No.

What keywords did you search in NGINX Ingress controller issues before filing this one? (If you have found any duplicates, you should instead reply there.):

reload annotations config reload

BUG REPORT:

NGINX Ingress controller version:

quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.22.0

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.9", GitCommit:"e6ab4ee54f71e7a403cc733534bab86fd959ecb7", GitTreeState:"clean", BuildDate:"2018-10-16T12:14:47Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.6", GitCommit:"b1d75deca493a24a2f87eb1efde1a569e52fc8d9", GitTreeState:"clean", BuildDate:"2018-12-16T04:30:10Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

What happened:

When changing the annotation on an ingress the config is not reloaded, for example:

Changing

    nginx.ingress.kubernetes.io/session-cookie-name: "FOO"

to

    nginx.ingress.kubernetes.io/session-cookie-name: "BAR"

will not trigger an config reload. Therefore the cookiename stays FOO. If one restarts the nginx-controllers or changes something like the the rules section (f.e. changing a path) the config is picked up normally (including the annotation, so that the cookie is then BAR).

What you expected to happen:

In nginx-ingress-controller:0.21.0 the config is reloaded when changing the annotation. I would expect the same behaviour.

How to reproduce it (as minimally and precisely as possible):

It should be easily reproducible with something like https://github.com/kubernetes/ingress-nginx/blob/master/docs/examples/affinity/cookie/ingress.yaml - my configuartion looks nearly the same, but has two rules which does not seem to matter.

Also the issue was discovered while testing version 0.22.0 - the same config works fine with 0.21.0.

For the logs:

I can neither see any of those:
No configuration change detected, skipping backend reload.
Configuration changes detected, backend reload required.
Backend successfully reloaded.

@msiuts msiuts changed the title No reload when changing annotations (f.e. No config reload is triggered when changing annotations (f.e. nginx.ingress.kubernetes.io/session-cookie-name) Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant