ModSecurity module is always loaded, even when not active

[tammert]

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

NGINX Ingress controller version:
Since 08-10-2017.

What happened:

ingress-nginx/rootfs/etc/nginx/template/nginx.tmpl

Line 19 in 79c52cf

load_module /etc/nginx/modules/ngx_http_modsecurity_module.so;

The ModSecurity module is always loaded, even if ModSecurity it not enabled. Other parts of the template are dependent on the actual configuration:

ingress-nginx/rootfs/etc/nginx/template/nginx.tmpl

Line 1158 in 79c52cf

{{ if (or $location.ModSecurity.Enable $all.Cfg.EnableModsecurity) }}

What you expected to happen:
ModSecurity module is only loaded when it is activated by configuration.

Anything else we need to know:
If you agree it would be better only to load this module when ModSec is enabled, I can submit a PR for this :).

[ElvinEfendi]

@tammert it would indeed be better to not load the module if it won't be used as long as achieving it does not require complex logic or add performance penalty to new config rendering.

[tammert]

@ElvinEfendi @aledbf I'll pick this up, so please assign it to me.