Install manifests use :master image even in tagged commits

[ikorolev93]

NGINX Ingress controller version:
Starting from 0.27.0 and up

Kubernetes version (use kubectl version):

Environment:

• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

What happened:
Tried to upgrade my existing kustomize-based installation just by replacing the git tag for remote base. Ended up having quay.io/kubernetes-ingress-controller/nginx-ingress-controller:master in the manifests (as a workaround I patched it in my kustomization.yaml).

Checking the official documentation, it also features :master images (docs suggest to run kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/nginx-0.27.1/deploy/static/mandatory.yaml, which has :master tag).

What you expected to happen:
Having tagged commits reference an exact version, like it was in 0.26.2 and before.

What do you think went wrong?
#4887 was merged and it affected all tags after that

How to reproduce it:

curl -s https://raw.githubusercontent.com/kubernetes/ingress-nginx/nginx-0.27.1/deploy/static/mandatory.yaml | grep nginx-ingress-controller:master

Anything else we need to know:

/kind bug

[aledbf]

Closing. Please update to 0.28.0

[ikorolev93]

Okay, static manifests have the right version now, but deploy/cloud-generic/kustomization.yaml still points to master:

ingress-nginx/deploy/cloud-generic/kustomization.yaml

Lines 13 to 15 in 1f93cb8

	images:
	- name: quay.io/kubernetes-ingress-controller/nginx-ingress-controller
	newTag: master

even though deployment.yaml has the right version:

ingress-nginx/deploy/cloud-generic/deployment.yaml

Line 18 in 1f93cb8

image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.28.0