Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty 'default:' stanza in new LimitRange (v0.28) #4997

Closed
tobiasmcnulty opened this issue Feb 1, 2020 · 1 comment · Fixed by #4999
Closed

empty 'default:' stanza in new LimitRange (v0.28) #4997

tobiasmcnulty opened this issue Feb 1, 2020 · 1 comment · Fixed by #4999
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@tobiasmcnulty
Copy link

We deploy the Nginx ingress controller via Ansible and the openshift client with validation enabled.

It discovered that there is an empty (perhaps unnecessary?) default: stanza in the new LimitRange resource definition:

apiVersion: v1
kind: LimitRange
metadata:
  name: ingress-nginx
  namespace: ingress-nginx
  labels:
    app.kubernetes.io/name: ingress-nginx
    app.kubernetes.io/part-of: ingress-nginx
spec:
  limits:
  - default:
    min:
      memory: 90Mi
      cpu: 100m
    type: Container

Could this be removed (or the appropriate defaults specified)? The exact error is:

failed: [my-cluster] (item=../kubernetes/ingress-nginx/mandatory.yaml) => {
    "ansible_loop_var": "item",
    "changed": false,
    "item": "../kubernetes/ingress-nginx/mandatory.yaml"
}

MSG:

LimitRange ingress-nginx: resource definition validation error at spec.limits.0.default: None is not of type 'object'

Thanks!

@tobiasmcnulty tobiasmcnulty added the kind/bug Categorizes issue or PR as related to a bug. label Feb 1, 2020
@aledbf aledbf mentioned this issue Feb 1, 2020
8 tasks
@tobiasmcnulty
Copy link
Author

@aledbf Many thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant