Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update github.com/paultag/sniff dependency #5033

Closed
ingvarm-gr opened this issue Feb 7, 2020 · 0 comments · Fixed by #5035
Closed

Need to update github.com/paultag/sniff dependency #5033

ingvarm-gr opened this issue Feb 7, 2020 · 0 comments · Fixed by #5035
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ingvarm-gr
Copy link

ingvarm-gr commented Feb 7, 2020

Due to paultag/sniff#12 and paultag/sniff#9 being merged yester day (2020-02-06, for those reading in the future), one or both of "re-vendor the library" and/or "update go.mod" should be done.

This is tangentially related to #775 (which was fixed, I believe, in the vendored copy of the library in PR #777, but possibly un-done in PR #4012).

I am willing to try to cut a PR for this (should only be two files, after all), but it might be quicker if someone more familiar with the ingress-nginx code base does it.

@ingvarm-gr ingvarm-gr added the kind/bug Categorizes issue or PR as related to a bug. label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant