-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx-ingress-controller 0.9.0-beta.10 not updating configuration #945
Comments
@stibi do you see a Edit: updates not necessarily require a reload. |
you are right that the log snippet was taken when updating an ingress. I have deleted it (btw,
and then created it again:
But no reload for the Btw, reload is not triggered for |
Only if you change the host, path or the endpoints (of the service) are updated |
I'm not sure what could be causing it, but my first guess is to review pod permissions given to nginx-ingress-controller. There are examples here: https://github.com/kubernetes/ingress/tree/master/examples/rbac/nginx. I'll admit it took me a while to get this sorted out to get it all working. Maybe watch for log messages that indicate any lack of permissions? |
Yes, RBAC is a thing I will look at today. Thanks for the hint! |
@stibi please update the image to |
no change :( Still the same problem. |
@stibi please update to |
no luck |
@stibi can you send the complete log? (please check my message in slack) |
How likely is it a bug or a problem with configuration on my side? I'll try to take a look on the code, to find out what is going on… |
@stibi I cannot reproduce this issue. Can you try to create an example that I can follow? |
I'm trying to realiably reproduce this, right now I think the problem is when an ingress contains more than one host rule in A new ingress with one rule triggers reload, a modification of an ingres with just one rule too…but once there are more rules, it doesn't do the reload. I'm spinning up a clean local k8s cluster, to verify this in a different environment than my dev and prod clusters. |
Could you try these steps to reproduce the problem?
I was digging in the code, I have some idea how it all works now, so I did this patch: stibi@299d4c3 It fixed the problem, the reload is triggered as expected…but I'm not really sure I have fixed the root cause. I'm trying to cover this with tests, because I still don't have the "aha" moment :) |
@stibi thank you for the report and finding the issue |
@stibi please check 0.9.0-beta.11 |
@aledbf Is this fixed in 0.9.0? I still got this issue for some reason. Config map seem OK, it appear But after, Do I miss something? |
Also |
For workaround, I've to edit |
Hi guys,
I have just deployed the 0.9.0-beta.10 nginx controller on my cluster, but I see the same problem as was described before here.
When I create a new ingress, I can see that the controller notice the event:
But no
ingress backend successfully reloaded...
message is logged and the new host block is not present in thenginx.conf
.I have to kill all the nginx-controller pods to get the ingress reflected in the
nginx.conf
.I have the controller deployed as daemonset, if that is useful information.
I'm not sure if RBAC is involved in this somehow? I have not configured that for nginx controller yet, I have to take a look what it is about, quite a few new things here since I last visited :)
Thanks for help! 💯
The text was updated successfully, but these errors were encountered: