Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change missing secret name log level to V(3) #1031

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

jcmoraisjr
Copy link
Contributor

This is a proposal of changing a log entry from warning to V(3).Info. The motivation of this change is that a missing secret name on Spec.TLS is a valid configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Jul 27, 2017
@aledbf
Copy link
Member

aledbf commented Jul 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.955% when pulling 4453a06 on jcmoraisjr:jm-fix-noisy-log into ce5e399 on kubernetes:master.

@aledbf aledbf merged commit 37375ae into kubernetes:master Jul 27, 2017
@jcmoraisjr jcmoraisjr deleted the jm-fix-noisy-log branch July 28, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants