Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the same udp port and tcp port, update nginx.conf error #1078

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

chenpengdev
Copy link

becase there is no check protocol, when service use same port, nginx.conf only exist tcp port information。

...
  ports:
  - name: "80"
    port: 80
    protocol: TCP
    targetPort: 80
  - name: 80udp
    port: 80
    protocol: UDP
    targetPort: 80
...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 45.012% when pulling fa2c422 on ghostcloud-cn:fixcmupdate into 9b80d3b on kubernetes:master.

@aledbf aledbf self-assigned this Aug 7, 2017
@aledbf
Copy link
Member

aledbf commented Aug 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2017
@aledbf
Copy link
Member

aledbf commented Aug 7, 2017

@chenpengdev thanks!

@aledbf aledbf merged commit 413b4ad into kubernetes:master Aug 7, 2017
@chenpengdev chenpengdev deleted the fixcmupdate branch August 7, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants