Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Todo:convert sequence to table #1139

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Fix Todo:convert sequence to table #1139

merged 1 commit into from
Aug 16, 2017

Conversation

zjj2wry
Copy link

@zjj2wry zjj2wry commented Aug 16, 2017

fix // TODO: convert test cases to tables

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.699% when pulling ce3abe2 on zjj2wry:fix-convert-todo into 7891ed6 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 16, 2017
@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

@zjj2wry thanks!

@aledbf aledbf merged commit 053f665 into kubernetes:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zjj2wry @k8s-reviewable @coveralls @aledbf @k8s-ci-robot