Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in multiple docs #1142

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Fix typo in multiple docs #1142

merged 1 commit into from
Aug 16, 2017

Conversation

asifdxtreme
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

@asifdxtreme please squash the commits

@asifdxtreme
Copy link
Contributor Author

@aledbf thanks will do the same, generally to squash the commits I have to clone the code in my laptop and then squash and push it back whereas currently I prefer doing online edit for docs typo fixes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 44.7% when pulling 26a83365369c7cba5d68237f4b6621adccc9fb94 on asifdxtreme:patch-7 into 06beed4 on kubernetes:master.

@asifdxtreme
Copy link
Contributor Author

@aledbf Thanks for the suggestion, I have squashed my commits and made 1 single commit, and sorry for delay as my network is very very slow so it takes hours to clone and push the code change

@aledbf aledbf self-assigned this Aug 16, 2017
@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

@asifdxtreme thanks!

@aledbf aledbf merged commit 38fd544 into kubernetes:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants