-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation for client-body-buffer-size per location #1186
Conversation
317ffe5
to
53bf1c5
Compare
d4f9948
to
8caeb5b
Compare
8caeb5b
to
ff83a35
Compare
Currently only working on creation, but update is not configuring the Annotation name was changed to |
If invalid value is provided ingress-controller will fail as follows:
Would this be expected behavior? |
ff83a35
to
30d4cca
Compare
@aledbf two questions: 1.) Do annotation values regularly need validation, for example in
2.) Should the location parameter for Thanks again and have a good night! |
1.) yes, we need to add that feature but not in this PR :) 2.) this is done each time the sync loop is executed |
Adds an annotation which allows for client-body-buffer-size to be configured per specific locations specified in the ingress resource yaml.
Ingress Resource YAML:
produces https://pastebin.com/0eSbjHfx in which you can see that It also updates each time a change is made. |
30d4cca
to
e9ffbf0
Compare
@aledbf ready for review. My only question is if |
No, only the the paths in the ingress. |
/lgtm |
@diazjf thanks! |
Adds an annotation which allows for client-body-buffer-size to
be configured per specific locations specified in the ingress
resource yaml. Fixes #826