Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to disable SSL passthrough #1190

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Add flag to disable SSL passthrough #1190

merged 1 commit into from
Aug 21, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 21, 2017 •
edited
Loading

Also sets the default to false.

fixes #1017

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.382% when pulling daa9fea on aledbf:disable-ssl-passthrough into a0e4661 on kubernetes:master.

@aledbf aledbf merged commit 6ef6343 into kubernetes:master Aug 21, 2017
@aledbf aledbf deleted the disable-ssl-passthrough branch August 21, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perfomance penalty for Nginx Ingress Controller vs Nginx
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot