Add flag to disabling node listing #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/L
|
cc @aledbf, this is the PR for what I brought up in #sig-network |
chancez
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@chancez thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to run nginx ingress isolated in it's own namespace, without having to setup a ClusterRole/ClusterRoleBinding, this makes it possible by disabling the node informer.
Note that this will mean the ingress controller is unable to get the list of IP address/fqdns where the ingress controller is currently running, and will be unable to update ingress status with that information. Since this isn't critical to to ingress functioning in all cases, this should be fine, and this configuration is disabled by default, and should only be used when trying to run isolate the ingress controller to it's namespace.
I wasn't sure about the flag naming, but it can be updated. Also, I considered defaulting this to true if force-isolate-namespace is true, but decided to hold off on that.