Increase coverage in template.go for nginx controller #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/L
diazjf
commented
Sep 10, 2017
| @@ -434,12 +437,6 @@ func buildRateLimit(input interface{}) []string { | |||
| limits = append(limits, limit) | |||
| } | |||
|
|
|||
| if loc.RateLimit.RPM.Limit > 0 { | |||
There was a problem hiding this comment.
These lines of code are a duplicate.
There was a problem hiding this comment.
This is not duplicated RPM != RPS
There was a problem hiding this comment.
Just noticed! Thanks @aledbf I just pushed the fix.
diazjf
commented
Sep 10, 2017
| @@ -434,12 +437,6 @@ func buildRateLimit(input interface{}) []string { | |||
| limits = append(limits, limit) | |||
| } | |||
|
|
|||
| if loc.RateLimit.RPM.Limit > 0 { | |||
| limit := fmt.Sprintf("limit_req zone=%v burst=%v nodelay;", | |||
| loc.RateLimit.RPM.Name, loc.RateLimit.RPM.Burst) | |||
There was a problem hiding this comment.
Unrelated to this PR, but I have a few questions on this particular section:
- What happens if
loc.RateLimit.RPM.Limit> 0, butloc.RateLimit.RPM.Burstdoes not exist? - Should we look for
loc.RateLimit.RPM.Burstinstead?
Adds some of the missing unit tests to template.go for the nginx controller.
diazjf
force-pushed
the
template-unit-tests
branch
from
8c75f50
to
c4293bc
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@diazjf thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some of the missing unit tests to template.go for the nginx controller.