Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content and descriptions about nginx's configuration #136

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Add content and descriptions about nginx's configuration #136

merged 2 commits into from
Jan 19, 2017

Conversation

chentao1596
Copy link

@chentao1596 chentao1596 commented Jan 17, 2017 •
edited
Loading

Hi, different things happened, but all the changed contents belong to the same file, so I take them as the same PR. For details, please refer to the commit message, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.522% when pulling c080454 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

cmluciano
cmluciano reviewed Jan 17, 2017
View reviewed changes
Copy link
Contributor

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@chentao1596 chentao1596 force-pushed the add-info-about-MapHashBucketSize branch 3 times, most recently from fe11e8f to 4fbe1ed Compare January 18, 2017 02:17
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.522% when pulling 4fbe1ed on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling 4fbe1ed on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling b6463c2 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.522% when pulling d0a6427 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@chentao1596 chentao1596 force-pushed the add-info-about-MapHashBucketSize branch 5 times, most recently from 16062ff to af8f288 Compare January 18, 2017 02:39
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.522% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@chentao1596
Copy link
Author

chentao1596 commented Jan 18, 2017 •
edited
Loading

@cmluciano I am very sorry that i can't see the content of your comment because of its not displayed properly. But, i find some contents has been changed in the other PR(#132), so i removed them and just only retain the different contents.
I am very sorry to trouble with you, PTAL, thank you!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 42.584% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.522% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 42.522% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling af8f288 on chentao1596:add-info-about-MapHashBucketSize into e55d13d on kubernetes:master.

@euank euank mentioned this pull request Jan 18, 2017
Closed
@aledbf aledbf self-assigned this Jan 19, 2017
@aledbf
Copy link
Member

aledbf commented Jan 19, 2017

/lgtm

@aledbf
Copy link
Member

aledbf commented Jan 19, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit 7553ab3 into kubernetes:master Jan 19, 2017
@chentao1596 chentao1596 deleted the add-info-about-MapHashBucketSize branch January 20, 2017 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano cmluciano left review comments

Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @cmluciano @k8s-ci-robot @chentao11596