Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference to const #138

Merged
merged 1 commit into from
Jan 18, 2017
Merged

reference to const #138

merged 1 commit into from
Jan 18, 2017

Conversation

caiyixiang
Copy link
Contributor

it's should be better that reference to const

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 42.584% when pulling 5131b76 on caiyixiang:const-reference into e55d13d on kubernetes:master.

@aledbf aledbf self-assigned this Jan 18, 2017
@aledbf
Copy link
Member

aledbf commented Jan 18, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2017
@aledbf
Copy link
Member

aledbf commented Jan 18, 2017

@caiyixiang thanks!

@aledbf aledbf merged commit 28c6725 into kubernetes:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caiyixiang @k8s-reviewable @coveralls @aledbf @k8s-ci-robot