Correct Error Handling to avoid panics and add more logging to template #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/M
diazjf
force-pushed
the
empty-strings
branch
from
ef53db9
to
3f3e48b
Compare
When a type error is found we return an empty object of the expected type(Example: return "" for string return type). Also makes adds logging to all errors caused by type and corrects all related logging for consistency.
diazjf
force-pushed
the
empty-strings
branch
from
3f3e48b
to
0c17825
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@diazjf thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type error is found we return an empty object of the expected type (Example: return "" for string return type). Also adds logging to all errors caused by type and corrects all related logging for consistency.